Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): dependencies not resolving for request-scoped lazy providers #14792

Merged

Conversation

anizozina
Copy link
Contributor

@anizozina anizozina commented Mar 17, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: Closes #14791

What is the new behavior?

Skipping creation of new providers if they are marked as request-scoped and have annotation in the score of module.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4024810b-d45d-4299-a49e-467c8f8e9ca4

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 89.293%

Files with Coverage Reduction New Missed Lines %
packages/core/injector/module.ts 1 85.14%
Totals Coverage Status
Change from base Build 44c104f1-8e85-45d8-85b0-095b2f828590: 0.001%
Covered Lines: 7147
Relevant Lines: 8004

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies are not resolved when using lazy load module and request-scoped providers
3 participants