Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make isHttpError check stricter #14753

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

glebbash
Copy link

@glebbash glebbash commented Mar 4, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #14738

What is the new behavior?

The new logic is stricter and almost the same as the one in http-errors library.

Additional check for expose property for example should remove a lot of false positives like ResponseError from ElasticSearch SDK.

Does this PR introduce a breaking change?

Not sure

@coveralls
Copy link

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 68c3bd7c-e773-48d8-8b6a-74e3bd54e306

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 89.284%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/exceptions/base-exception-filter.ts 4 5 80.0%
Totals Coverage Status
Change from base Build 93d1c816-7d3c-41c5-b5e6-91437bb286af: -0.008%
Covered Lines: 7149
Relevant Lines: 8007

💛 - Coveralls

@glebbash
Copy link
Author

glebbash commented Mar 4, 2025

Added FastifyError handling

@glebbash
Copy link
Author

glebbash commented Mar 5, 2025

@kamilmysliwiec what does the status: blocked mean?

@kamilmysliwiec
Copy link
Member

@glebbash it means that this PR may introduce a breaking change. Something to investigate, evaluate risks etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants