feat!: remove inheritPropertyInitializers
from PartialType
(for discussion)
#923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1425
In this old issue from the graphql repo it is suggested that
PartialType
shouldn't inherit property initializers which makes total sense since aCreateCatDto
may provide default value for some fields but aUpdateCatDto
that marks all fields as optional should leave all unset fields undefined to avoid unwanted changes.We can make this an option but it feels like it should be the default behavior since I can't think of any case where it can be useful.
What is the new behavior?
PartialType
doesn't inherit property initializers.Does this PR introduce a breaking change?
Other information