Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(recipes/necord): add necord documentation #2656

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

SocketSomeone
Copy link
Contributor

@SocketSomeone SocketSomeone commented Mar 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

To introduce new library necord

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Already added to https://github.com/nestjs/awesome-nestjs and Discord Server as Forum channel

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the docs look fantastic. Could you revert the whitespace changes in the menu.components and recipes.module? I don't think converting the whitespace to tabs was intentional, just a side effect of a save command of your IDE.

@kamilmysliwiec I can vouch for this library, I've used it for some trivial Discord integration bots before and will keep using it and probably make a Nest bot for our server as well when I've got some time.

content/recipes/necord.md Outdated Show resolved Hide resolved
@SocketSomeone SocketSomeone force-pushed the feautre/recipes/necord branch from 3ef3d86 to eb68dc6 Compare March 14, 2023 18:12
@SocketSomeone SocketSomeone requested a review from jmcdo29 March 14, 2023 19:12
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll see what Kamil thinks

@SocketSomeone SocketSomeone requested review from jmcdo29 and micalevisk and removed request for jmcdo29 March 15, 2023 22:33
@KieronWiltshire
Copy link

Any update on this please?

@kamilmysliwiec
Copy link
Member

While I appreciate your effort and I'm excited to see more and more great OSS Nest integrations, I'm not convinced that we should keep adding them to the Recipes section. This category (Recipes) already contains several packages that are not maintained by us (are not part of the official NestJS organization) and so the documentation got quite difficult to maintain moving forward as we're not familiar with the API of those packages ourselves

@KieronWiltshire
Copy link

While I appreciate your effort and I'm excited to see more and more great OSS Nest integrations, I'm not convinced that we should keep adding them to the Recipes section. This category (Recipes) already contains several packages that are not maintained by us (are not part of the official NestJS organization) and so the documentation got quite difficult to maintain moving forward as we're not familiar with the API of those packages ourselves

while I agree with you somewhat, I would argue that NestJS is the go-to framework for building discord bots. Necord is hitting 8.3k downloads per month.

@SocketSomeone
Copy link
Contributor Author

SocketSomeone commented Apr 4, 2023

@kamilmysliwiec

Hi there,
Thank you for answer!

that are not maintained by us (are not part of the official NestJS organization) and so the documentation got quite difficult to maintain moving forward as we're not familiar with the API of those packages ourselves

I understand your concerns, that's why we are making the information more generalized, adding links to our own documentation for advanced info and a hint that library not managed by NestJS. It will also not be difficult for me to maintain documentation on your site, and there are also many cool guys who are ready to help with this work. I am constantly monitoring any changes, including the necord channel (Discord server).

Necord is hitting 8.3k downloads per month.

It is true that the Necord community is growing, and we want to reach as many people as possible. As @jmcdo29 mentioned, he is interested in creating a bot for your server using Necord.

This category (Recipes) already contains several packages

I also agree with @samchon (#2571 (comment)). It would be cool to create a new category for great OSS Nest integrations not managed by Nest.

While I appreciate your effort and I'm excited to see more and more great OSS Nest integrations

We love you guys no matter what! NECORD 💖 NestJS
Thanks for your hard work!

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Oct 18, 2024

I'm still hesitant about adding yet another recipe to the docs but if @jmcdo29 and @micalevisk say we should do this then let's move ahead.

Thanks @SocketSomeone, fantastic job! Apologies for the delay

@kamilmysliwiec kamilmysliwiec merged commit 3a3f109 into nestjs:master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants