Conversation
|
Test deployment successful!! (2026-03-27T03:53:42Z) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Ahoy! This patch brings the magic of automatic color schemes to the mkdocs.yml and adds specific styles for the slate theme in theme.css, along with fixing some embarrassing typos in the comments. However, the stylesheet be littered with commented-out lines and strange sorcery like /*-- that need to be cast overboard to keep the ship tidy. If a line serves no purpose, it should walk the plank instead of just being labeled as useless!
| /* --md-accent-bg-color: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /* --md-primary-fg-color--light: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /*--md-primary-bg-color: var(--reannz-orange); */ /* text/icon color for head bar */ | ||
| /* --md-accent-fg-color--light: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /* --md-default-fg-color: var(--reannz-orange); */ /* main text color, sub H1 headers too */ | ||
| /* --md-default-bg-color: var(--reannz-orange); */ /* main background color */ | ||
| /* --md-code-fg-color: var(--reannz-orange); */ /* main color for code text */ | ||
| /* --md-code-bg-color: var(--reannz-orange); */ /* main color for code background */ | ||
| /* --md-typeset-color: var(--reannz-orange); */ /* main text color, sub H1 headers too */ |
There was a problem hiding this comment.
Ahoy! This block be cluttered with commented-out lines, like barnacles on a hull. And that comment on line 27 starts with /*--... what kind of sorcery is that? If these styles are not needed, send 'em to Davy Jones' locker to keep the stylesheet shipshape. A tidy ship is a fast ship!
References
- As per the ship's articles, all feedback must be delivered in the tongue of a 17th-century pirate (Line 4). (link)
| /* --md-accent-bg-color: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /* --md-primary-fg-color--light: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /*--md-primary-bg-color: var(--reannz-orange); */ /* text/icon color for head bar */ | ||
| /* --md-accent-fg-color--light: var(--reannz-orange); */ /* cannot figure what this one does */ | ||
| /* --md-default-fg-color: var(--reannz-orange); */ /* main text color, sub H1 headers too */ | ||
| /* --md-default-bg-color: var(--reannz-orange); */ /* main background color */ | ||
| /* --md-code-fg-color: var(--reannz-orange); */ /* main color for code text */ | ||
| /* --md-code-bg-color: var(--reannz-orange); */ /* main color for code background */ | ||
| /* --md-typeset-color: var(--reannz-orange); */ /* main text color, sub H1 headers too */ |
There was a problem hiding this comment.
Avast ye! More commented-out code clutterin' the deck. And that comment on line 42 starts with /*--... are ye daft? If these styles serve no purpose, cast 'em overboard!
References
- As per the ship's articles, all feedback must be delivered in the tongue of a 17th-century pirate (Line 4). (link)
|
|
||
| .cards { | ||
| color: var(--md-typeset-color); | ||
| color: var(--md-typeset-color); /* I don't think this does anything */ |
There was a problem hiding this comment.
Blast me eyes! The comment says 'I don't think this does anything'. If ye suspect this line is a stowaway with no purpose, don't just label it, make it walk the plank! Remove the line to keep the code clean.
References
- As per the ship's articles, all feedback must be delivered in the tongue of a 17th-century pirate (Line 4). (link)
1 participant
Making dark mode a bit more functional