You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Ahoy there, matey! This here pull request be a motley crew o' changes, mostly battlin' with yer dependencies, hoistin' new versions of many a Python package, and even swappin' out yer mkdocs_quiz for a custom-rigged branch to fix some template woes. Ye also be scuttlin' an errant {% endif %} from yer overrides/main.html and hidin' a tutorial banner in yer theme.css with a display: none; trick. Now, for the treasure map o' feedback: that extra endif ye cast overboard from overrides/main.html was a proper menace, good riddance to it, though it makes one wonder how such a tangle came to be in the first place, eh? While ye've hidden that banner in theme.css with a display: none;, a true sailor would scuttle the whole thing from the HTML if it be truly unwanted, else ye be just sweepin' yer mess under the rug, savvy? Lastly, ye be sailin' with yer own custom-rigged quiz plugin in requirements.in, a clever trick indeed, but mind ye, relying on yer own privateer's branch can lead to choppy waters if that branch be not kept shipshape with the main fleet. Hope ye don't forget where ye buried this treasure!
The reason will be displayed to describe this comment to others. Learn more.
Blast and confound it! An extra 'endif' be lurkin' here, causin' all sorts o' trouble for yer template. Good riddance to it, though it makes one wonder how such a tangle came to be in the first place, eh?
The reason will be displayed to describe this comment to others. Learn more.
Arrr, ye be hidin' this banner like a coward hides his treasure! While 'tis a quick way to make it vanish from sight, a true sailor would scuttle the whole thing from the HTML if it be truly unwanted. Else, ye be just sweepin' yer mess under the rug, savvy?
The reason will be displayed to describe this comment to others. Learn more.
Aha! Ye be sailin' with yer own custom-rigged quiz plugin, eh? 'Tis a clever trick to fix yer template woes, but mind ye, relying on yer own privateer's branch can lead to choppy waters if that branch be not kept shipshape with the main fleet. Hope ye don't forget where ye buried this treasure!
The reason will be displayed to describe this comment to others. Learn more.
Arrr, another version o' 'anyio' be sailin' in! Keep a sharp eye on these new provisions, matey. Sometimes new cargo brings unforeseen squalls, even if it promises smoother seas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.