Skip to content

Remove banner#1198

Merged
CallumWalley merged 1 commit intomainfrom
remove-banner
Mar 19, 2026
Merged

Remove banner#1198
CallumWalley merged 1 commit intomainfrom
remove-banner

Conversation

@CallumWalley
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

Test deployment successful!! (2026-03-19T23:10:47Z)
Preview available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/support-docs/remove-banner

See all deployed demo sites

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Ahoy! So ye've decided to hide the banner by burying it under some commentin' marks. A fine choice for a landlubber, I suppose. But a true code-sea dog would send that dead code to Davy Jones' Locker for good. I've marked the spot where ye should be diggin' to remove the cursed code entirely. Don't be leavin' it around to haunt us later.

Comment on lines 92 to +97
// Remove me later
showOfficeBanner().then(() => {
if (!document.getElementById("calendar-banner")){
addBanner(`<p>Registrations now open for <a href=https://www.eventbrite.co.nz/e/introduction-to-high-performance-computing-hpc-carpentry-tickets-1984247473608>Introduction to HPC Carpentry Workshop</a> on 24th March from 10am to 3pm.</p>`, 'workshop-banner');
}
});
// showOfficeBanner().then(() => {
// if (!document.getElementById("calendar-banner")){
// addBanner(`<p>Registrations now open for <a href=https://www.eventbrite.co.nz/e/introduction-to-high-performance-computing-hpc-carpentry-tickets-1984247473608>Introduction to HPC Carpentry Workshop</a> on 24th March from 10am to 3pm.</p>`, 'workshop-banner');
// }
// });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Shiver me timbers! Instead of just commentin' out this old code, why not send it to the deep? Dead code tells no tales, and it certainly doesn't belong in our pristine codebase. Let's get rid of it entirely, shall we? It's what a proper captain would do.

@CallumWalley CallumWalley merged commit 5ef6299 into main Mar 19, 2026
8 checks passed
@CallumWalley CallumWalley deleted the remove-banner branch March 19, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant