Conversation
Summary of ChangesHello @jen-reeve, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a substantial refactoring of the 'Submitting your first job' tutorial, transforming it from a comprehensive, standalone guide into a more concise overview that points to dedicated resources for in-depth information. The intent is to create a clearer learning path for users by centralizing detailed command explanations and reference material in appropriate cheat sheets and guides, while the tutorial focuses on the workflow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Old guide now made new,Links now lead to deeper lore,Learning finds its way. Footnotes
|
|
Test deployment successful!! (2026-03-22T07:29:59Z)
See all deployed demo sites |
Signed-off-by: jen-reeve <31419037+jen-reeve@users.noreply.github.com>
Changed some code block types
WesHarrell
left a comment
There was a problem hiding this comment.
This looks good to me. Happy for this to replace previous pages
Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
… into first-job-tutorial
Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
The pull request introduces a new 'Tutorials' section to the documentation, including new pages for 'Introduction To HPC' covering Bash Shell, Environment & Modules, Parallel Computing, Resources, Scaling, and Submitting Your First Job. It also adds new admonition types (time, objectives, keypoints, next) and a quiz plugin for tutorials, along with corresponding CSS styling. Several existing documentation links were updated to point to the new tutorial pages. Review comments highlighted issues such as incorrect CSS syntax for background-color in theme.css, a missing sum_matrix.r file for an example script in the 'Submitting Your First Job' tutorial, and pedagogical ordering concerns in the 'Bash Shell' tutorial where relative paths are used before being explained. Inconsistencies were noted in example commands for node names and glob patterns in the 'Bash Shell' and 'Resources' tutorials. Additionally, there were several minor content issues including incomplete TODOs, an empty line in a code block, and incorrect admonition types (postrequisite instead of next) in the new tutorial pages.
Note: Security Review did not run due to the size of the PR.
| nano example_job.sh | ||
| ``` | ||
|
|
||
| <!-- TODO: change this script to not require another file --> |
|
|
||
| ## Creating directories | ||
|
|
||
| <!-- NOTE: This bit uses relative paths even though the concept hasn't been introduced yet. --> |
| `?` is also a wildcard, but it matches exactly one character. So the command: | ||
|
|
||
| ```sh | ||
| ls !!!?.* |
There was a problem hiding this comment.
docs/Tutorials/Introduction_To_HPC/Submitting_Your_First_Job.md
Outdated
Show resolved
Hide resolved
docs/Tutorials/Introduction_To_HPC/Submitting_Your_First_Job.md
Outdated
Show resolved
Hide resolved
mkdocs.yml
Outdated
| slurm: slurm-25.05.6 | ||
| project_code: nesi99991 | ||
| working_directory: ["nesi", "nobackup", "nesi99991", "introhpc2603"] | ||
| example_script: "example script" |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Cal <35017184+CallumWalley@users.noreply.github.com>
… into first-job-tutorial
No description provided.