Skip to content

Add symlinks#59

Open
CallumWalley wants to merge 2 commits intomainfrom
add-symlinks
Open

Add symlinks#59
CallumWalley wants to merge 2 commits intomainfrom
add-symlinks

Conversation

@CallumWalley
Copy link
Member

nn_doomed_list => autodelete_list
nn_seff => seff
nn_storage_quota => storage_quota

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new symbolic links to provide alternative, potentially shorter or more descriptive, names for existing files or paths. This change aims to improve usability by offering aliases for specific file references.

Highlights

  • Symlink Creation: Created three new symlinks: autodelete_list, seff, and storage_quota, pointing to nn_doomed_list, nn_seff, and nn_storage_quota respectively.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is titled 'Add symlinks' and the description suggests creating aliases for scripts. However, the implementation adds plain text files instead of symbolic links. For example, the file autodelete_list is created with the text content nn_doomed_list, which will not function as a link to execute the nn_doomed_list script. This needs to be corrected by creating proper symbolic links for autodelete_list, seff, and storage_quota.

@@ -0,0 +1 @@
nn_doomed_list No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file appears to be intended as a symbolic link to nn_doomed_list, but it has been created as a regular text file. This will not function as an executable link. To fix this, please replace this file with a proper symbolic link using ln -s nn_doomed_list autodelete_list and commit the link.

@@ -0,0 +1 @@
nn_seff No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file appears to be intended as a symbolic link to nn_seff, but it has been created as a regular text file. This will not function as an executable link. To fix this, please replace this file with a proper symbolic link using ln -s nn_seff seff and commit the link.

@@ -0,0 +1 @@
nn_storage_quota No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file appears to be intended as a symbolic link to nn_storage_quota, but it has been created as a regular text file. This will not function as an executable link. To fix this, please replace this file with a proper symbolic link using ln -s nn_storage_quota storage_quota and commit the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant