change source link to github and increase lmod version

[lbrick]

No description provided.

[gemini-code-assist]

Hello @lbrick, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request by @lbrick. The primary goal of this PR is to update the version of Lmod being installed by the Ansible role and to change the source URL for downloading the Lmod archive from SourceForge to GitHub. This involves updating the default version variable and modifying the download, extraction, and cleanup tasks in the installation playbook to reflect the new version and the change in source and archive format (.tar.bz2 to .tar.gz).

Highlights

• Change Lmod Download Source: The source URL for downloading the Lmod archive has been switched from SourceForge to the official GitHub repository, and the archive format expected is now .tar.gz instead of .tar.bz2.

Changelog

• ansible/roles/nesi.lmod/defaults/main.yml
  • Updated the lmod_version variable from 8.7 to 8.7.55.
• ansible/roles/nesi.lmod/tasks/install.yml
  • Changed the ansible.builtin.get_url task to download from the GitHub releases page using a .tar.gz archive.
  • Updated the ansible.builtin.unarchive task to extract the .tar.gz archive.
  • Modified the ansible.builtin.file task for cleanup to remove the .tar.gz archive.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively updates the Lmod version and changes its download source from SourceForge to GitHub. The changes are clear, and the Ansible tasks are updated consistently to reflect the new source and archive format. Overall, good work on this update!

Summary of Findings

• Remove commented-out code: The old SourceForge URL is commented out in ansible/roles/nesi.lmod/tasks/install.yml (line 12). It's generally better to remove such dead code to improve readability and maintainability. A review comment has been added for this.
• Missing newline at end of file: The file ansible/roles/nesi.lmod/tasks/install.yml does not end with a newline character after the changes. While not critical, it's a common convention for text files to end with a newline for better compatibility with various Unix tools and to adhere to POSIX standards for text files. This is a low-severity issue and was not commented on directly due to the current review settings focusing on medium severity and above.

Merge Readiness

The pull request is well-structured and the changes are logical. However, there is one medium-severity suggestion regarding a commented-out line of code that should ideally be removed for better maintainability. I've set the status to REQUEST_CHANGES to address this point. Once that minor adjustment is made, the PR should be in good shape for merging. Please note that I am an AI assistant and cannot approve pull requests; ensure other reviewers approve this code before merging.

[gemini-code-assist]

This commented-out line appears to be the old URL for downloading Lmod from SourceForge. To improve code clarity and maintainability, it's generally recommended to remove dead or obsolete code rather than commenting it out. Could this line be removed to keep the playbook cleaner?