fix checking curl response and filling error#78
Open
armax15 wants to merge 15 commits intonervetattoo:masterfrom
Open
fix checking curl response and filling error#78armax15 wants to merge 15 commits intonervetattoo:masterfrom
armax15 wants to merge 15 commits intonervetattoo:masterfrom
Conversation
…unctions, response will never be false (empty string instead) cause of this exceptions will never throw.
- add options to request method - add rawRequest to client - add scroll wrapper - add some bulk methods - add method parameter and return value types - bump min php version to 7.1 - replace ob_* to RETURN_TRANSFER (memory leaks not actual for PHP 5.4+) - introduce fork capability (based on pid, forkManager interface required)
Cleanup code, code style, php7.1+
fixed problems with accessing on array offset and uninitialized strin…
…client added function for custom protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After changing CURLOPT_RETURN_TRANSFER to getting response with ob_ f…nctions, response will never be false (empty string instead) cause of this exceptions will never throw.