Refresh device-related assigns when receiving connection online message, replace mox with mimic
#1738
Conversation
| @@ -43,15 +43,11 @@ defmodule NervesHubWeb.Live.Devices.Show do | |||
| |> page_title("Device #{device.identifier} - #{product.name}") | |||
| |> assign(:tab_hint, :devices) | |||
| |> assign(:device, device) | |||
| |> assign(:device_connection, device_connection(device)) | |||
| |> assign(:console_active?, Tracker.console_active?(device)) | |||
| |> assign(:deployment, device.deployment) | |||
There was a problem hiding this comment.
I think this needs to move into general_assigns as well
| socket = | ||
| socket | ||
| |> general_assigns(device) | ||
| |> assign(:device_connection, Connections.get_latest_for_device(device.id)) |
There was a problem hiding this comment.
I think we should reload the device, then do the general_assigns, and since we will be reloading the device we won't need to do line 82, instead we can move |> assign(:device_connection, device_connection(device)) from mount into general_assigns
There was a problem hiding this comment.
When setting assigns.device_connection, which should we prefer? Connections.get_latest_for_device(device.id) or device_connection(device)? I think that in the lifecycle events that we're talking about (mount, connection status inline, connection status offline) we should always fetch the latest device connection record. Thoughts?
There was a problem hiding this comment.
If we are fetching the Device, the latest device connection is included, but if we aren't fetching the Device (like when the status changes to "offline") we don't need to fetch the Device, we can just use Connections.get_latest_for_device(device.id), does that make sense?
Yes! On it. |
nshoes
force-pushed
the
refresh-device-assigns-when-coming-online
branch
2 times, most recently
from
ba27bb2 to
0501845
Compare
nshoes
force-pushed
the
refresh-device-assigns-when-coming-online
branch
from
0501845 to
7ecd5ab
Compare
nshoes
force-pushed
the
refresh-device-assigns-when-coming-online
branch
from
7ecd5ab to
df70ecb
Compare
|
@joshk test added! Do you have any opinion on |
Go for gold! |
nshoes
changed the title
mox with mimic
nshoes
force-pushed
the
refresh-device-assigns-when-coming-online
branch
from
5817b49 to
640f1cb
Compare
| @@ -104,7 +102,6 @@ | |||
| "telemetry_metrics": {:hex, :telemetry_metrics, "1.0.0", "29f5f84991ca98b8eb02fc208b2e6de7c95f8bb2294ef244a176675adc7775df", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "f23713b3847286a534e005126d4c959ebcca68ae9582118ce436b521d1d47d5d"}, | |||
| "telemetry_metrics_statsd": {:hex, :telemetry_metrics_statsd, "0.7.1", "3502235bb5b35ce50d608bf0f34369ef76eb92a4dbc8708c7e8780ca0da2d53e", [:mix], [{:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:telemetry_metrics, "~> 0.6 or ~> 1.0", [hex: :telemetry_metrics, repo: "hexpm", optional: false]}], "hexpm", "06338d9dc3b4a202f11a6e706fd3feba4c46100d0aca23688dea0b8f801c361f"}, | |||
| "telemetry_poller": {:hex, :telemetry_poller, "1.1.0", "58fa7c216257291caaf8d05678c8d01bd45f4bdbc1286838a28c4bb62ef32999", [:rebar3], [{:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "9eb9d9cbfd81cbd7cdd24682f8711b6e2b691289a0de6826e58452f28c103c8f"}, | |||
| "telemetry_registry": {:hex, :telemetry_registry, "0.3.2", "701576890320be6428189bff963e865e8f23e0ff3615eade8f78662be0fc003c", [:mix, :rebar3], [{:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "e7ed191eb1d115a3034af8e1e35e4e63d5348851d556646d46ca3d1b4e16bab9"}, | |||
There was a problem hiding this comment.
This and opentelemetry_liveview above are unused deps that weren't unlocked and cleaned, so I removed them.
No description provided.