Skip to content

Commit

Permalink
Log unsupported API version when requesting device extensions (#1701)
Browse files Browse the repository at this point in the history
  • Loading branch information
elinol authored Dec 17, 2024
1 parent 3057064 commit 1d0967e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
10 changes: 10 additions & 0 deletions lib/nerves_hub/audit_logs/templates.ex
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
defmodule NervesHub.AuditLogs.Templates do
alias NervesHub.AuditLogs

require Logger

def audit_resolve_changed_deployment(device, reference_id) do
description =
if device.deployment_id do
Expand Down Expand Up @@ -28,4 +30,12 @@ defmodule NervesHub.AuditLogs.Templates do

AuditLogs.audit_with_ref!(device, device, description, reference_id)
end

def audit_unsupported_api_version(device) do
description =
"device #{device.identifier} could not get extensions: Unsupported API version."

AuditLogs.audit!(device, device, description)
Logger.info("[DeviceChannel] #{description}")
end
end
3 changes: 2 additions & 1 deletion lib/nerves_hub_web/channels/device_channel.ex
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ defmodule NervesHubWeb.DeviceChannel do
# Earlier versions of nerves_hub_link don't have a fallback for unknown messages,
# so check version before requesting extensions
if is_safe_to_request_extensions?(socket.assigns.device_api_version),
do: push(socket, "extensions:get", %{})
do: push(socket, "extensions:get", %{}),
else: Templates.audit_unsupported_api_version(device)

{:noreply, socket}
end
Expand Down

0 comments on commit 1d0967e

Please sign in to comment.