Skip to content

DRAFT: Security / Permissions in Neos 9 #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
skurfuerst wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Draft

DRAFT: Security / Permissions in Neos 9 #4014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Classes/Controller/BackendServiceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
use Neos\Neos\Domain\Service\WorkspacePublishingService;
use Neos\Neos\Domain\Service\WorkspaceService;
use Neos\Neos\FrontendRouting\SiteDetection\SiteDetectionResult;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationService;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationInterface;
use Neos\Neos\Service\UserService;
use Neos\Neos\Ui\Application\ChangeTargetWorkspace;
use Neos\Neos\Ui\Application\DiscardAllChanges;
Expand Down Expand Up @@ -178,7 +178,7 @@ class BackendServiceController extends ActionController

/**
* @Flow\Inject
* @var ContentRepositoryAuthorizationService
* @var ContentRepositoryAuthorizationInterface
*/
protected $contentRepositoryAuthorizationService;

Expand Down Expand Up @@ -597,8 +597,9 @@ public function getAdditionalNodeMetadataAction(array $nodes): void
$nodePrivileges = $this->contentRepositoryAuthorizationService->getNodePermissions($node, $this->securityContext->getRoles());
$result[$nodeAddress->toJson()] = [
'policy' => [
// TODO: support für "create" -> CreateNodeDialog vorfiltern
'disallowedNodeTypes' => [], // not implemented for Neos 9.0
'canRemove' => $nodePrivileges->edit,
'canRemove' => $nodePrivileges->remove,
'canEdit' => $nodePrivileges->edit,
'disallowedProperties' => [] // not implemented for Neos 9.0
]
Expand Down
4 changes: 2 additions & 2 deletions Classes/Fusion/Helper/WorkspaceHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Neos\Flow\Security\Context;
use Neos\Neos\Domain\Service\UserService;
use Neos\Neos\Domain\Service\WorkspaceService;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationService;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationInterface;
use Neos\Neos\Ui\ContentRepository\Service\WorkspaceService as UiWorkspaceService;

/**
Expand Down Expand Up @@ -58,7 +58,7 @@ class WorkspaceHelper implements ProtectedContextAwareInterface

/**
* @Flow\Inject
* @var ContentRepositoryAuthorizationService
* @var ContentRepositoryAuthorizationInterface
*/
protected $contentRepositoryAuthorizationService;

Expand Down
4 changes: 2 additions & 2 deletions Classes/Infrastructure/Configuration/ConfigurationProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
use Neos\Flow\Security\Context as SecurityContext;
use Neos\Neos\Domain\Model\WorkspaceClassification;
use Neos\Neos\Domain\Service\WorkspaceService;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationService;
use Neos\Neos\Security\Authorization\ContentRepositoryAuthorizationInterface;
use Neos\Neos\Service\UserService;
use Neos\Neos\Ui\Domain\InitialData\CacheConfigurationVersionProviderInterface;
use Neos\Neos\Ui\Domain\InitialData\ConfigurationProviderInterface;
Expand All @@ -45,7 +45,7 @@ final class ConfigurationProvider implements ConfigurationProviderInterface
protected WorkspaceService $workspaceService;

#[Flow\Inject]
protected ContentRepositoryAuthorizationService $contentRepositoryAuthorizationService;
protected ContentRepositoryAuthorizationInterface $contentRepositoryAuthorizationService;

#[Flow\Inject]
protected CacheConfigurationVersionProviderInterface $cacheConfigurationVersionProvider;
Expand Down
Loading