Skip to content

BUGFIX: Skip content childnodes when returning document tree nodes #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 8.3
Choose a base branch
from

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Jun 24, 2025

What I did

Speed up response time for return nodes for the document tree by a factor of up to 5x when uncollapsing a document or searching. With ~200 documents (e.g. Blog folder with many articles) the following results were achieved:

  • Uncollapse blog page with ~200 articles:
    • Response size is reduced from 162 KB to 132 KB -> -19%
    • Response time is reduced from 2.5s to 0.6s -> -75%
  • Search in the document tree for the same blog posts (also ~200 results)
    • Response size is reduced from 193 KB to 163 KB -> -16%
    • Response time is reduced from 2s to 0.5s -> -75%

How I did it

  • Skip content child nodes if we only request document types depending on the clients requested usage
  • Don't recalculate nodetype filter for each rendered node

How to verify it

  • Tests still work
  • Node trees behave the same way except that uncollapsing and search are much faster

Resolves: #1508

@Sebobo Sebobo added Bug Label to mark the change as bugfix Performance 8.3 labels Jun 24, 2025
@Sebobo Sebobo changed the title WIP BUGFIX: Skip content childnodes when rendering document tree nodes WIP BUGFIX: Skip content childnodes when returning document tree nodes Jun 24, 2025
@Sebobo Sebobo force-pushed the bugfix/improve-document-tree-loading branch from 0b9d12e to 8cc1292 Compare June 24, 2025 20:33
@Sebobo Sebobo changed the title WIP BUGFIX: Skip content childnodes when returning document tree nodes BUGFIX: Skip content childnodes when returning document tree nodes Jun 25, 2025
@Sebobo Sebobo marked this pull request as ready for review June 25, 2025 07:16
@Sebobo
Copy link
Member Author

Sebobo commented Jun 25, 2025

The follow up for this topic would be to get rid of all children in the response and only provide a parent id for building the tree and a hasChildNodes flag for the collapsible state check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix Performance
Projects
Status: Reviews
Development

Successfully merging this pull request may close these issues.

1 participant