Skip to content

Conversation

dasoe
Copy link
Contributor

@dasoe dasoe commented Jun 21, 2025

What I did
Add ckeditor plugin 'autoformat' for basic Markdown support

@github-actions github-actions bot added Feature Label to mark the change as feature 9.0 labels Jun 21, 2025
@Sebobo Sebobo moved this to Reviews in PostCon Sprint 2025 Jun 24, 2025
README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again,

In this pull request, you’ll find the changes from the other two PRs as well. :)

Thanks a bunch for taking care of it and bringing the neos-ui a bit forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks a lot!
I do have to admit, that the overlapping changes make it a bit harder to review this. E.g. are the 28 changes in manifest.config.js all related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh Man, sorry for that!!
Not used to it, but it makes perfectly sense to do every commit from "base level". Still learning, please be patient...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be sorry! Thanks a lot for the contribution <3

@Sebobo Sebobo force-pushed the feature/markdowninckeditor branch from e2f62b6 to c029899 Compare July 21, 2025 07:09
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! I removed the unrelated changes and tested its functionality.

@markusguenther @mhsdesign currently one cannot disable this feature. So if someone doesn't want to have the auto formatting, we don't give them them the choice.
Question: Should we introduce a setting like for the auto paragraph?

@Sebobo
Copy link
Member

Sebobo commented Jul 21, 2025

And we should create and target 9.1 for this. -> Done

@Sebobo Sebobo added 9.1 and removed 9.0 labels Jul 21, 2025
@Sebobo Sebobo changed the base branch from 9.0 to 9.1 July 21, 2025 07:12
@Sebobo Sebobo requested a review from mhsdesign August 18, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.1 Feature Label to mark the change as feature
Projects
Status: Reviews
Development

Successfully merging this pull request may close these issues.

4 participants