-
-
Notifications
You must be signed in to change notification settings - Fork 144
FEATURE: Add plugin Markdown 'autoformat' for basic Markdown support #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.1
Are you sure you want to change the base?
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again,
In this pull request, you’ll find the changes from the other two PRs as well. :)
Thanks a bunch for taking care of it and bringing the neos-ui a bit forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks a lot!
I do have to admit, that the overlapping changes make it a bit harder to review this. E.g. are the 28 changes in manifest.config.js
all related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooh Man, sorry for that!!
Not used to it, but it makes perfectly sense to do every commit from "base level". Still learning, please be patient...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be sorry! Thanks a lot for the contribution <3
e2f62b6
to
c029899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! I removed the unrelated changes and tested its functionality.
@markusguenther @mhsdesign currently one cannot disable this feature. So if someone doesn't want to have the auto formatting, we don't give them them the choice.
Question: Should we introduce a setting like for the auto paragraph?
And we should create and target 9.1 for this. -> Done |
What I did
Add ckeditor plugin 'autoformat' for basic Markdown support