-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Simplify publish workflow #3909
FEATURE: Simplify publish workflow #3909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tests locally and ran into an interesting use case:
When I have a conflict on Page 1 and then use the "simple" publish on Page 2, the conflict resolution opens. This is a little bit strange from the user's point of view, could we allow publishing the page even if there is a conflict on a different page?
0032cae
to
3c320e3
Compare
…shing workflow to skip confirmation
the state state?.ui?.remote?.isPublishing and state?.ui?.remote?.isDiscarding is dead empty and was moved to state?.cr?.publishing?.mode
…in use discarding is currently done always with a popup so we dont need to disable the publishing dropdown - similar to synchronizing which is also not handled. Further its removed because the `Discarding...` label is not even translated.
... by reusing the translation keys from Neos.Neos.Ui:PublishingDialog
f28e211
to
6189127
Compare
This change was approved in the Neos 9 meeting on 24.01 by christian paula and denny. |
Based on #3910
The change #3759 introduced a new publishing confirmation modal that provides information and will run the publish or discard operation when continuing.
This guarantees that no publish is triggered accidentally and also that the Ui is locked during publishing so that its not possible to edit content which would raise a server error. The workflow looked like this:
We discussed a lot of pros and cons if the workflow should be simplified and to which extend mainly because the Neos 8.3 publish workflow was a simple one click operation with no further interaction.
TLTR: Minor publish operations - just publishing the document - should be simplified to be a simple one click operation like in Neos 8.3.
Reasons for simplifying the workflow of publishing the current document
Case 1.) For quick servers the publish is done in no time while the Ui indicates this with a spinner in the publish dropdown:
Bildschirmaufnahme.2025-01-23.um.10.45.19.mov
Case 2.) For slightly longer operations after a timeout a modal with animation is shown (like in the other workflows) so that its not possible to make changes via the Ui, which would cause an exception:
Bildschirmaufnahme.2025-01-23.um.10.46.21.mov