-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: 9.0 infinite (real) reloads after exception #3748
BUGFIX: 9.0 infinite (real) reloads after exception #3748
Conversation
633c038
to
c4ffef9
Compare
c4ffef9
to
93a8a85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to look at this again, it seems after navigating via the site tree the infinite reloads continue.
Basically there are two ways to trigger this bug, one via navigating via the iframe to a broken page or via the document tree.
Both should stop loading after encountering the first error. (The orange indicator might continue spinning but there should not be any real reloads)
In 8.3 always absolute src are used for ui.contentCanvas.src
: "http://127.0.0.1:8081/neos/preview?node%5B__contextNodePath%5D=%2Fsites%2Fneosdemo%2Ffeatures%2Fnavigation-elements%2Ffirst-item%40user-admin%3Blanguage%3Den_US"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Hey @mhsdesign, |
Remove origin from Iframe url
a56aa04
to
4cb1428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks now it works. Neither the inline navigation (via the iframe) nor the navigation via the document tree leads to endless exception flodding like currently:
Bildschirmaufnahme.2024-04-27.um.10.50.38.mov
That way we restored the same behaviour as in Neos 8.3
What I did
Update the NodeInfoHelper to build an initial absolute URL, instead of a relative one.
How to verify it
Throw an exception (or return an abnormal response) in any places and expect the iframe to be only loaded once.
The orange loading bar will keep spinning but that is part of #3477.
But currently this results in an endless reload, because in the condition of the frame
win.location.href
will not equalthis.props.src
causingwin.location.replace(this.props.src)
being retriggered infinitely:neos-ui/packages/react-ui-components/src/Frame/frame.tsx
Line 96 in 5e16758