Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Add subtree tag restoration tests #5518

Merged
merged 2 commits into from
Mar 25, 2025
Merged

TASK: Add subtree tag restoration tests #5518

merged 2 commits into from
Mar 25, 2025

Conversation

nezaniel
Copy link
Member

This adds test cases which ensure that inherited subtree tags are properly restored when recreating a deleted hierarchy relation

Upgrade instructions

none

Review instructions

none

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Add test cases that ensure that inherited subtree tags are properly r…
b88da62 
…estored when recreating a deleted hierarchy relation
@nezaniel nezaniel requested a review from bwaidelich March 18, 2025 10:36
@nezaniel nezaniel requested review from kitsunet and mhsdesign March 18, 2025 10:36
mhsdesign
mhsdesign approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jup makes sense as new edges are created as node variation normally doesnt has to do that as the edge exists only not its node row

@mhsdesign mhsdesign merged commit d1735a4 into neos:9.0 Mar 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nezaniel @mhsdesign