Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Find nodes marked as removed in other dimension #5498

Merged

Conversation

beromir
Copy link

@beromir beromir commented Mar 6, 2025

If you delete a node in a workspace that has already been deleted in the workspace in another dimension, the node is not marked as removed in the database.

With this PR, nodes marked as removed are also found in non-live workspaces.

related: #5031

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 8.3 label Mar 6, 2025
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I've tested that and it seems to make totally sense.

As I missed it in first place: This is an issue due to baseworkspace hierarchy. The first removal ends up as an unpublished change in the base workspace. The fix ensures, that we will find this change and recognize this node as "existing". So we need the shadow node for our dependent workspace, to make this second deletion publishable in our current workspace.

@dlubitz dlubitz requested a review from kitsunet March 14, 2025 09:07
@kitsunet kitsunet merged commit b8766e0 into neos:8.3 Mar 27, 2025
9 checks passed
@dlubitz dlubitz changed the title [BUGFIX] Find nodes marked as removed in other dimension BUGFIX: Find nodes marked as removed in other dimension Mar 27, 2025
@github-actions github-actions bot added the Bug label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants