Table.view onStoreRecordchange: refactor to call createViewData for the specific record #5179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Refactor
[ x] Other, please describe:
The
onStoreRecordChange
colspan implementation invokes createViewData to reprocess all items:The proposed change invokes createViewData to process only the single specified record. This works for any change that createViewData handles, not just colspan. For example it will work for
annotation.selected
processing, if that happens in createViewData.Does this PR introduce a breaking change? (check one)
What it does:
onStoreRecordChange
is empty now, it just callscreateViewData
.createViewData(inputData)
now tests whether inputData is a data array (from store & collection), or, a single record fromonStoreRecordChange
. If it is a single record there is some bookkeeping with the index values to process the record as a record array of length 1.It turns out that an initial loading of Store can trigger both the expected data array load event, and an equivalent series of recordChange events. To forestall that double processing, onStoreRecordChange is only enabled if
isLoaded === true
. When createViewData encounters a data/items array, it sets isLoaded to true.