Truncate long property values in tooltip #253
Merged
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentinD
force-pushed
the
tooltip-truncated
branch
from
e7e4837 to
52ff651
Compare
Collaborator
|
Could you share a screenshot please? |
Collaborator
Author
|
adamnsch
approved these changes
Nov 14, 2025
|
|
||
| ## Improvements | ||
|
|
||
| - Truncate large property values in the rendered output. |
Collaborator
There was a problem hiding this comment.
Even bug fix I would say :)
| if (tooltip !== null) { | ||
| this.hoverInteraction = new HoverInteraction(this.nvl) | ||
|
|
||
| const truncateValue = (value: any, maxLength: number = 100): string => { |
Collaborator
There was a problem hiding this comment.
Not sure this maxLength will be good for all window sizes, but let's not worry about it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref GDS-64