Fix how resolvers are handled during driver construction #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
approved these changes
Jun 7, 2024
| @@ -15,21 +15,24 @@ import java.util.concurrent.TimeUnit | |||
| import scala.collection.JavaConverters._ | |||
| import scala.language.implicitConversions | |||
| import org.apache.spark.internal.Logging | |||
| import org.jetbrains.annotations.TestOnly | |||
There was a problem hiding this comment.
this addition is probably not intentional?
There was a problem hiding this comment.
I actually added it two public functions on this class, as they were already commented as being public for test access.
| @Test | ||
| def shouldConstructDriverWithResolver(): Unit = { | ||
| val options: java.util.Map[String, String] = new java.util.HashMap[String, String]() | ||
| options.put(Neo4jOptions.URL, s"neo4j://localhost.localdomain:8888, bolt://localhost.localdomain:9999, ${server.getBoltUrl}") |
There was a problem hiding this comment.
So, I was just mapping localhost.localdomain:8888 to a set of localhost.localdomain:9999 (which is not accessible) and localhost:XYZ (which should be accessible) - and I expect the driver to establish a connection successfully.
Bu we need a response from drivers team for this - I believe there is a bug around this in the driver.
|
waiting for a driver fix for this one. |
fbiville
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how multiple URLs are handled when passed to
urloption during driver creation.