Send pipeline failed events to the event callback #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and failure event - add unit test
stellasia
force-pushed
the
feature/pipeline-failure-events
branch
from
1d0ed47 to
2094545
Compare
serengil
reviewed
Dec 11, 2025
| ) | ||
| raise e | ||
| end_time = default_timer() | ||
| logger.debug(f"PIPELINE FINISHED {run_id} in {end_time - start_time}s") |
Contributor
There was a problem hiding this comment.
nit: you may want to round the duration, otherwise it will show the duration with very high precision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure a
PIPELINE_FAILEDevent is always sent to the event callback when pipeline fails. Consequences:run_idcreation in the Pipeline class for better code orgType of Change
Complexity
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):