Expose all components in SimpleKGPipeline init and config #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
changed the title
src/neo4j_graphrag/experimental/pipeline/config/template_pipeline/simple_kg_builder.py
Show resolved
Hide resolved
src/neo4j_graphrag/experimental/pipeline/config/template_pipeline/simple_kg_builder.py
Show resolved
Hide resolved
|
Discussed offline, converting to draft again because exposing all components would lead to weird scenearios since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes all components in the SimpleKGPipeline constructor, ie make it possible to customize all the components in the pipeline, including the entity extractor and resolver.
I also took the opportunity to revisit some type definition to remove
type: ignorecomments by leveraging generics.Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):