Introduce aura_instance_id parameter #959
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
commented
Sep 18, 2025
| - `GraphDataScience::run_query` now supports setting the `mode` of the query to be used for routing. Previously queries would always route the leader of the cluster, assuming write mode. | ||
| - `GraphDataScience::run_query` now support setting `retryable` to enable a retry-mechanism for appropriate errors. This requires `neo4j>=5.5.0`. | ||
|
|
||
| - `GDsSessions.get_or_create` now allows to specify the `aura_instance_id`. This is required if the instance id could not be derived from the provided database connection URI. |
There was a problem hiding this comment.
make sure its part of the 1.18 release
allow to explicitly pass it. This is important if the original Aura instance id not part of the uri. Such as for multi-db support ref GDSA-283
FlorentinD
force-pushed
the
gds-session-override-instance-id
branch
from
38a229e to
e52a088
Compare
|
this override, is only important temporarily while the feature is still in EA. having this as a fallback option still seems like a good idea to me. thinking of the case where the customer has the original uri hidden. could be also a very rare use-case though. especially, would the user know instance_id? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to explicitly pass it.
This is important if the original Aura instance id not part of the uri. Such as for multi-db support
ref GDSA-283