Updated images #1210

lidiazuin · 2025-03-10T10:01:46Z

No description provided.

JPryce-Aklundh

Thanks @lidiazuin.
The images look good, except for:

graph_clause_where.svg (the replacement replaces the old image)
patterns-equijoins-solution_2.svg (I think the different solutions are less clear in this new format).

Also, how are you batching these updates? I see, e.g., that this PR replaces some but not all of the svgs in the Patterns chapter? Are those not replaced here not ready yet?

JPryce-Aklundh · 2025-03-12T08:39:10Z

modules/ROOT/pages/queries/basic.adoc

@@ -678,7 +678,7 @@ RETURN type(r) AS type, m.title AS movie

 The result shows that he has 13 outgoing relationships connected to 12 different `Movie` nodes (12 have the `ACTED_IN` type and one has the `DIRECTED` type).

-image::introduction_example1.svg[width="500",role="middle"]
+image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup]


Suggested change

image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup]

image::introduction-example1.svg[A Tom Hank Person node connected to Movie nodes via acted in relationships,width=600,role=popup]

modules/ROOT/pages/patterns/non-linear-patterns.adoc

Co-authored-by: Jens Pryce-Åklundh <[email protected]>

lidiazuin · 2025-03-12T09:47:50Z

graph_clause_where.svg (the replacement replaces the old image)

I don't understand your point here?

patterns-equijoins-solution_2.svg (I think the different solutions are less clear in this new format).

Isn't it the same image, only the nodes are organized differently? Maybe you can talk to Petar and explain to him what improvements could be made.

Also, how are you batching these updates? I see, e.g., that this PR replaces some but not all of the svgs in the Patterns chapter? Are those not replaced here not ready yet?

I'm adding all the images that Petar finished and sent to me in the first batch. I don't know in what order he's working with the images, but I would guess it's not after chapters since we have some missing, like the ones you pointed out.

JPryce-Aklundh · 2025-03-12T09:57:40Z

The WHERE graph was updated in cypher-25. Your image is a replacement of the image in dev/5.x.
I pointed out the difference in the google doc I shared with you and Petar.
They are not the same. The new one only differentiates the nodes within the cycle by the width of the rel - the old one used a different color for the rels outside the cycle, which, I think, is clearer.
https://neo4j.com/docs/cypher-manual/current/patterns/non-linear-patterns/
I will ask Petar
Ok, I was under the impression that all images had been completed (apart from the new ones in cypher 25, such as the WHERE graph)

lidiazuin · 2025-03-12T10:13:13Z

Would you like to revert the change in these two images and merge to publish the new ones or wait?

JPryce-Aklundh · 2025-03-12T10:51:46Z

where_clause.svg should be reverted, but I actually think it might be better to wait adding the images in the Patterns section until they are all done (i.e. all "patterns... .svg" files).

recrwplay · 2025-03-12T13:26:37Z

This PR includes documentation updates
View the updated docs at https://neo4j-docs-cypher-1210.surge.sh

Updated pages:

…of images that are not being used but were updated

neo-technology-commit-status-publisher · 2025-03-20T14:36:03Z

This PR includes documentation updates
View the updated docs at https://neo4j-docs-cypher-1210.surge.sh

Updated pages:

JPryce-Aklundh · 2025-04-04T09:19:56Z

modules/ROOT/pages/patterns/reference.adoc

@@ -2,6 +2,12 @@
 [[syntax-and-semantics]]
 = Syntax and semantics

+//Check Mark


What does this do? (Preview isnt working)

It replaces the current emoji ✅ for the checkmark we use in docs, so it should look like this instead:

…of images that are not being used but were updated

Publish from all the branches

Co-authored-by: AlexicaWright <[email protected]> Co-authored-by: Jens Pryce-Åklundh <[email protected]> Co-authored-by: David Oliver <[email protected]> Co-authored-by: Arne Fischereit <[email protected]> Co-authored-by: Tobias Johansson <[email protected]> Co-authored-by: Gemma Lamont <[email protected]> Co-authored-by: lidiazuin <[email protected]> Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: JPryce-Aklundh <[email protected]> Co-authored-by: Louise Söderström <[email protected]> Co-authored-by: Jack Waudby <[email protected]> Co-authored-by: Satia Herfert <[email protected]> Co-authored-by: Gustav Hedengran <[email protected]>

Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.

Original PR: neo4j#348 Fix unterminated example block in alias page.

This makes the example always return the same result by enforcing an ordering, so that we don't need to skip testing its result (this PR updates neo4j#405). The sense of the example is unaffected.

Original PR: neo4j#464 Cherry-pick excludes 5.6 specific content in original PR Co-authored-by: Therese Magnusson <[email protected]>

Original PR: neo4j#494

Co-authored-by: Satia Herfert <[email protected]> Co-authored-by: Hannes Sandberg <[email protected]> Co-authored-by: Nacho Cordón <[email protected]> Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: Pontus Melke <[email protected]>

Cherry-picked from neo4j#552

Co-authored-by: Jens Pryce-Åklundh <[email protected]> Co-authored-by: Bastien Louërat <[email protected]> Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: Lasse Heemann <[email protected]>

This PR updates 5.x with updates from PRs into dev that were not cherry-picked into 5.x at any point. While it looks like a lot of commits were missing, in the end it amounts to changes in 14 files, some of which are trivial and do not affect the content or output. I'd be happy to use 'squash and merge' to reduce this update to a single commit in 5.x

…order on the subsections (neo4j#569) Original PR: neo4j#568 authored-by: Therese Magnusson <[email protected]>

neo4j-docops-agent · 2025-05-21T10:06:04Z

This PR includes documentation updates
View the updated docs at https://neo4j-docs-cypher-1210.surge.sh

Updated pages:

Updated images

19a35b9

lidiazuin requested a review from JPryce-Aklundh March 10, 2025 10:01

JPryce-Aklundh reviewed Mar 12, 2025

View reviewed changes

Apply suggestions from code review

04b6b13

Co-authored-by: Jens Pryce-Åklundh <[email protected]>

Fixing line after review suggestion

70485f6

reverting image

3de0a3e

Second batch of images. Please refer to docs file for updated listed …

585dba3

…of images that are not being used but were updated

Final batch of updated images

1f9ec93

JPryce-Aklundh reviewed Apr 4, 2025

View reviewed changes

lidiazuin and others added 15 commits May 21, 2025 09:44

Delete modules/ROOT/images/graph-with-clause.svg

049709a

Merge branch 'cypher-25' into imagesrefresh

21de1bc

Updated images

11618f4

Second batch of images. Please refer to docs file for updated listed …

6772a86

…of images that are not being used but were updated

Final batch of updated images

9bf8057

Updated images after feedback on spreadsheet

cc20b58

rebase

eeb8213

Update publish.yml playbook (neo4j#244)

bd70990

Publish from all the branches

Document relationship key and uniqueness constraints (neo4j#225)

9e3d56a

Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.

Update CALL subquery examples for testing (neo4j#348) (neo4j#354)

d7f918e

Original PR: neo4j#348 Fix unterminated example block in alias page.

Mirror changes for testing in operators.adoc (neo4j#390, neo4j#395)

c6edab8

Make example in limit.adoc deterministic (neo4j#411)

9f46a4d

This makes the example always return the same result by enforcing an ordering, so that we don't need to skip testing its result (this PR updates neo4j#405). The sense of the example is unaffected.

Update show output column lists (neo4j#473)

ce4a076

Original PR: neo4j#464 Cherry-pick excludes 5.6 specific content in original PR Co-authored-by: Therese Magnusson <[email protected]>

Merge 5.6 PRs to 5.x (neo4j#480)

057eca1

JPryce-Aklundh and others added 10 commits May 21, 2025 11:35

New Administration chapter (neo4j#504)

b2ccc14

Original PR: neo4j#494

update all links to configs (neo4j#553)

13b0745

Cherry-picked from neo4j#552

Add 5.8 documentation for publication (neo4j#559)

fa7cb91

Co-authored-by: Jens Pryce-Åklundh <[email protected]> Co-authored-by: Bastien Louërat <[email protected]> Co-authored-by: Therese Magnusson <[email protected]> Co-authored-by: Lasse Heemann <[email protected]>

Add NODES 23 ad (neo4j#561)

bc8a197

Reorder deprecations, additions and removals file to have consistent …

ccc5315

…order on the subsections (neo4j#569) Original PR: neo4j#568 authored-by: Therese Magnusson <[email protected]>

fixing rebase

978d629

fixing rebase

f199ab1

page order-by

9ec5c46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated images #1210

Updated images #1210

Uh oh!

lidiazuin commented Mar 10, 2025

Uh oh!

JPryce-Aklundh left a comment

Uh oh!

JPryce-Aklundh Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

lidiazuin commented Mar 12, 2025 •

edited

Loading

Uh oh!

JPryce-Aklundh commented Mar 12, 2025 •

edited

Loading

Uh oh!

lidiazuin commented Mar 12, 2025

Uh oh!

JPryce-Aklundh commented Mar 12, 2025

Uh oh!

recrwplay commented Mar 12, 2025

Uh oh!

neo-technology-commit-status-publisher commented Mar 20, 2025

Uh oh!

JPryce-Aklundh Apr 4, 2025

Uh oh!

lidiazuin Apr 4, 2025

Uh oh!

neo4j-docops-agent commented May 21, 2025

Uh oh!

Uh oh!

	image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup]
	image::introduction-example1.svg[A Tom Hank Person node connected to Movie nodes via acted in relationships,width=600,role=popup]

Updated images #1210

Are you sure you want to change the base?

Updated images #1210

Uh oh!

Conversation

lidiazuin commented Mar 10, 2025

Uh oh!

JPryce-Aklundh left a comment

Choose a reason for hiding this comment

Uh oh!

JPryce-Aklundh Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lidiazuin commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JPryce-Aklundh commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lidiazuin commented Mar 12, 2025

Uh oh!

JPryce-Aklundh commented Mar 12, 2025

Uh oh!

recrwplay commented Mar 12, 2025

Uh oh!

neo-technology-commit-status-publisher commented Mar 20, 2025

Uh oh!

JPryce-Aklundh Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

lidiazuin Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

neo4j-docops-agent commented May 21, 2025

Uh oh!

Uh oh!

lidiazuin commented Mar 12, 2025 •

edited

Loading

JPryce-Aklundh commented Mar 12, 2025 •

edited

Loading