Skip to content

fix: adoc header #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ToyB0x
Copy link

@ToyB0x ToyB0x commented Apr 23, 2025

Thank you for the great documentation.

The current .adoc file headers were causing many images to appear as broken links when viewed on Github,
so I fixed this in this PR.
(The modified header is the same as in ref.)

Before After
image image

|

@ToyB0x
Copy link
Author

ToyB0x commented Apr 23, 2025

@fbiville @jexp @JMHReif
Could someone please review?
(Feel free to merge or close it)

@jexp
Copy link
Contributor

jexp commented Apr 24, 2025

Sorry, we need to do it differently, as the img variable is provided in the build process to point to the right images on s3

Possibly {img-img}

As default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants