Add NFT to TokenManagement #4365
Open
+634
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vncoelho
reviewed
Dec 5, 2025
ajara87
reviewed
Dec 6, 2025
shargon
reviewed
Dec 7, 2025
src/Neo/SmartContract/StorageItem.cs
Outdated
| /// </summary> | ||
| /// <param name="integer">The integer value to set.</param> | ||
| public void Set(BigInteger integer) | ||
| public BigInteger Set(BigInteger integer) |
Member
There was a problem hiding this comment.
This can be void as before, just return the sum in the Add method
| [ContractMethod(CpuFee = 1 << 17, StorageFee = 1 << 10, RequiredCallFlags = CallFlags.All)] | ||
| internal async Task<UInt160> MintNFT(ApplicationEngine engine, UInt160 assetId, UInt160 account, Map properties) | ||
| { | ||
| if (properties.Count > 8) |
Member
Author
There was a problem hiding this comment.
It is checked in AddTotalSupply().
| const FindOptions options = FindOptions.KeysOnly | FindOptions.RemovePrefix; | ||
| var prefixKey = CreateStorageKey(Prefix_NFTOwnerUniqueIdIndex, account); | ||
| var enumerator = snapshot.Find(prefixKey).GetEnumerator(); | ||
| return new StorageIterator(enumerator, 21, options); |
Member
There was a problem hiding this comment.
Suggested change
| return new StorageIterator(enumerator, 21, options); | |
| return new StorageIterator(enumerator, Prefix_NFTOwnerUniqueIdIndex, options); |
Member
Author
There was a problem hiding this comment.
21 is the prefix length to be removed.
superboyiii
reviewed
Dec 10, 2025
Comment on lines
139
to
144
| engine.SnapshotCache.Add(key, new(new NFTState | ||
| { | ||
| AssetId = assetId, | ||
| Owner = account, | ||
| Properties = properties | ||
| })); |
Member
There was a problem hiding this comment.
Suggested change
| engine.SnapshotCache.Add(key, new(new NFTState | |
| { | |
| AssetId = assetId, | |
| Owner = account, | |
| Properties = properties | |
| })); | |
| var storageItem = new StorageItem(new NFTState | |
| { | |
| AssetId = assetId, | |
| Owner = account, | |
| Properties = properties | |
| }); | |
| storageItem.Seal(); // Seal immediately to prevent post-validation mutations | |
| engine.SnapshotCache.Add(key, storageItem); |
Member
There was a problem hiding this comment.
properties can be changed. We need Seal() for storageItem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add NFT to TokenManagement
Type of change
How Has This Been Tested?
Checklist: