Check if all used CRS in a schematisation match #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change CRS in all tests to 28892 * Disable RasterHasMatchingEPSGCheck (should be fixed in ticket 414) * Remove geo_query and use explicit queries instead now transformations are no longer needed
* Add EPSGGeomCheck to compare geometry epsg to given epsg
…ke it testable * Add tests for get_epsg_data
margrietpalm
changed the title
margrietpalm
changed the title
…on of raster_columns
…the schema to threedi-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
model_checker_context). I chose this approach to prevent having to lookup the EPSG for every check.Also added checks for valid model epsg; where valid means a known EPSG code that refers to a CRS that uses meters and is projected (37394e2)
Note that I removed a bunch of checks because I think they are no longer needed because they are done for the single model crs. But a sanity check on this would be nice (2382deb)