Add temporal attribute to RasterBlock + base Clip logic on it
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanbasten-ns
approved these changes
Aug 15, 2024
arjanverkerk
approved these changes
Aug 16, 2024
dask_geomodeling/raster/elemwise.py
Outdated
| else: | ||
| return timedeltas[0] | ||
|
|
||
| @property | ||
| def temporal(self): | ||
| """If any of the sources is temporal, the result is temporal.""" |
There was a problem hiding this comment.
This is enforced by the init(), but maybe not the most adequate description for this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
RasterBlock.temporalattribute with a default implementation that guesses whether the raster is temporal based on timedelta and period.We can gradually improve this by providing
temporalfrom the various sources.I went through the blocks and fixed some low-hanging fruit for propagating
temporalthrough the operations.Also: many deprecation warnings that I solved with pinning versions. See issues #118 , #119 , #120