Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNA fetch script #11

Merged
merged 1 commit into from
Mar 27, 2019
Merged

DNA fetch script #11

merged 1 commit into from
Mar 27, 2019

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Mar 14, 2019 •
edited
Loading

This adds a python script that will fetch the device DNA from the FPGA using the existing fpga_config framework.

DNA_scripts have been added to nengo-pynq or nengo-de1.

To use this run python DNA_extractor.py --fpga_name <board-name from fpga_config>

Testing
I tried this with both PYNQ and DE1 boards

TODO

xchoo
xchoo requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some comments that need addressing.

nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/DNA_extractor.py Outdated Show resolved Hide resolved
xchoo
xchoo requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small comments. Check the DNA-script branches of the nengo-pynq and nengo-de1 repos as well.

nengo_fpga/dna_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/dna_extractor.py Outdated Show resolved Hide resolved
xchoo
xchoo requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changes on the comments. Forgot that they needed tweaking.

docs/getting_started.rst Outdated Show resolved Hide resolved
xchoo
xchoo requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this. Oops!

nengo_fpga/dna_extractor.py Outdated Show resolved Hide resolved
nengo_fpga/dna_extractor.py Show resolved Hide resolved
@xchoo
Copy link
Member

xchoo commented Mar 26, 2019

Okay. This looks good to be merged now.

@bmorcos bmorcos changed the title WIP: DNA fetch script DNA fetch script Mar 27, 2019
@bmorcos
Add script to read Device DNA
b499754 
- Add DNA script to fpga_config
- Add DNA extractor to docs
@bmorcos bmorcos merged commit b499754 into master Mar 27, 2019
@bmorcos bmorcos deleted the DNA-fetch branch March 27, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchoo xchoo xchoo requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmorcos @xchoo