Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fpga_pes_ensemble_network and DNA_extractor scripts to maximize reuse of SSH code. #13

Open
xchoo opened this issue Mar 18, 2019 · 1 comment

Comments

@xchoo
Copy link
Member

xchoo commented Mar 18, 2019

The fpga_pes_ensemble_network code and the DNA_extractor code contain a lot of duplicate code. They should be refactored (make an SSH class or something) to reduce code copy/pasting. Refactoring the code would also make it easier to user the same SSH communication methods for future fpga ensemble / networks.

@xchoo xchoo mentioned this issue Mar 18, 2019
3 tasks
@bmorcos
Copy link
Contributor

bmorcos commented Mar 20, 2019

Maybe this is also a good time to look at adding a flag to indicate that SSH has connected. Using this flag to indicate to the socket that it should start expecting values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants