Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SLURM and Conda support #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added SLURM and Conda support #152

wants to merge 1 commit into from

Conversation

xchoo
Copy link
Member

@xchoo xchoo commented Jun 23, 2021

Added SLURM, and alias support for CI scripts.

  • Modified exe function in base_script.sh.template to support aliases
  • Modified remote-script.sh.template to perform docs tasks for any script ending in "docs"
  • Added SLURM support with slurm-script.sh.template
  • SLURM support wraps given commands with SLURM commands using bash aliases
  • Note: slurm-script supports aliasing of generic commands, while changes to exe function support aliasing of commands called with exe
  • Added usage instructions for slurm-script.sh.template and remote.sh.template
  • Updated secret.tar.enc to use abrghost instead of abrgl
  • Added remote slurm test script as an example

How has this been tested?
Tested by running test suite. Also checked that slurm runs are being executed properly.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?
Start with slurm-script.sh.template

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Still to do:

@xchoo xchoo force-pushed the slurm_and_conda branch 3 times, most recently from 5f39391 to 74f03f9 Compare June 23, 2021 19:23
CHANGES.rst Outdated Show resolved Hide resolved
@xchoo xchoo force-pushed the slurm_and_conda branch 4 times, most recently from b2e7f37 to 4793e83 Compare June 24, 2021 13:43
@xchoo xchoo force-pushed the slurm_and_conda branch 3 times, most recently from 090e421 to b0c9ce1 Compare June 24, 2021 19:26
@xchoo
Copy link
Member Author

xchoo commented Jun 24, 2021

Okay. I think this is pretty much stable now. I left the slurm-script the way it is since it seemed to be the only way generic commands (in the wrapped script) worked with the aliases. The changes to exe does give it support for SLURM, so if we can guarantee that every command in the wrapped script is run with exe, we can remove slurm-script.

- Modified exe function in base_script.sh.template to support
  aliases
- Modified remote-script to do docs things for all scripts ending
  with "docs"
- Added SLURM support with slurm-script.sh.template
- SLURM support wraps given commands with SLURM commands using bash
  aliases
- Added usage instructions for slurm-script.sh.template and
  remote.sh.template
- Updated secret.tar.enc to use abrghost instead of abrgl
@xchoo xchoo force-pushed the slurm_and_conda branch from aef033f to d1bc77d Compare June 29, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants