UI Improvements #253
Open
UI Improvements #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This translation modifies UI text to follow GNOME HIG writing style guidelines (https://developer.gnome.org/hig/guidelines/writing-style.html) in English, without breaking other translations. Modifications include header capitalization, and ellipses on the 'Change Folder' button to indicate further action required.
Reason: The translation made no meaningful changes to the message IDs (in terms of adapting it to locale), and was out of date anyway. It would just conflict with the new 'en' translation for no real reason.
Reason: I think these icons better reflect the page contents.
Reason: Outside of header bars, buttons should contain either an icon or a label, and not both (https://developer.gnome.org/hig/patterns/controls/buttons.html).
Note: while not having labels does have a cleaner look, having labels on the buttons allows the user to hover over them and preview the URLs before they click on them. Also, prevents that 'ghost button' highlight when the action row is clicked and the button is activated -- it makes more sense for it to highlight with a label.
Reason: version_button was not a button, so its purpose is clearer as just text in a property row.
Reason: It makes more sense to have to have the shuffle mode option in only one place (the Settings page), than to have it appear twice. Plus, it allows the Gallery page to shine as a place to view and manage the user's individual Bing backgrounds, without the shuffle controls kind of randomly mishmashed with it.
The buttons look nice this way.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #252 based off
version-51branch.