Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pip is available when running the -no_extras tox factor #142

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

kurtmckee
Copy link
Contributor

I'm working to get the test suite passing locally -- it's been failing for multiple reasons, which has impaired my ability to thoroughly test other PRs I've submitted.

This PR addresses a missing pip dependency when using the tox-uv plugin; the tox environments are created without pip installed, which causes the -no_extras factors to fail. pip isn't added to the pip-compile-managed requirements files because pip-compile warns that "it is considered unsafe" to have pip listed in the requirements.

Fixed

  • Ensure that pip is available when running the -no_extras tox factor.

@nedbat
Copy link
Owner

nedbat commented Mar 13, 2025

I don't understand how the tox-uv plugin is involved. Can you show me how to reproduce the problem?

@kurtmckee
Copy link
Contributor Author

kurtmckee commented Mar 13, 2025

pipx install tox
pipx inject tox tox-uv

tox

The tox-uv plugin uses uv to create the virtual environments into which tox installs dependencies. However, uv doesn't automatically install pip.

I use the plugin because it helps my ailing old Windows laptop run tox test suites measurably faster, but it has a side-effect that usually doesn't affect test suites...unless they need to run pip. 😅

Adding pip as a listed requirement resolves the issue, and also makes the dependency explicit.

@kurtmckee kurtmckee force-pushed the ensure-pip-is-available branch from e4d2cb4 to 97ffa93 Compare March 13, 2025 11:56
@nedbat nedbat merged commit 3fd6b58 into nedbat:main Mar 13, 2025
7 checks passed
@kurtmckee kurtmckee deleted the ensure-pip-is-available branch March 13, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants