-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow integer md_header_level #137
Allow integer md_header_level #137
Conversation
Thanks! Can you take a look at the linter failures? |
Also, do you want to make a scriv fragment for the changelog? :) |
BTW, I just fixed the test suite issues, if you rebase on top of master. |
…should-be-read-as-an-int-in-toml-files
@nedbat, thank you for the advice! I fixed the lint errors and managed to add some test, as well as the changelog fragment. Please feel free to change this PR, if needed, to match the the project standards. And thank you for the scriv :) |
It seems that tests failures are not related to my changes |
They are related: you can't test TOML support on a version without toml lib. You need this line from the tests a few above yours:
|
Yes, my bad, I misinterpreted the tox log. Fixed. |
Thanks! |
A simple change fixing #90.
I tried to be as conservative as possible, letting
md_header_level
remainstr
internally and be converted fromint
on input. This change is backwards compatible and allows string values as before.