Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncap pylint-pytest in the dependency lists and lock files #127

Closed

Conversation

OlenaYefymenko
Copy link

@OlenaYefymenko OlenaYefymenko commented Apr 26, 2024

This patch removes the pylint-pytest from the constraints.txt file. This change also updates the dependency to the version v1.1.7 in requirements/dev.txt and requirements/quality.txt.

Fixes #125

@OlenaYefymenko OlenaYefymenko marked this pull request as draft April 26, 2024 13:10
This patch removes the pylint-pytest from the constraints.txt
file. This change also updates the dependency to the version v1.1.7
in requirements/dev.txt and requirements/quality.txt

Fixes nedbat#125
@OlenaYefymenko OlenaYefymenko marked this pull request as ready for review April 26, 2024 23:05
@nedbat
Copy link
Owner

nedbat commented May 5, 2024

Thanks for doing this, you did it exactly right. Unfortunately, the tests wouldn't still run on 3.7, so I dropped 3.7 support, and had to make upgrade to do that, which also meant I had to unpin this requirement, so it's all taken care of on main now.

@nedbat nedbat closed this May 5, 2024
@OlenaYefymenko
Copy link
Author

Thanks for doing this, you did it exactly right. Unfortunately, the tests wouldn't still run on 3.7, so I dropped 3.7 support, and had to make upgrade to do that, which also meant I had to unpin this requirement, so it's all taken care of on main now.

Understandable, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO][good first issue] Uncap pylint-pytest in the dependency lists and lock files
2 participants