On POSIX stop map_handle::commit() calling madvise() on non-file back…

…ed allocations.
ned14 · Aug 19, 2021 · 044418d · 044418d
1 parent 4186176
commit 044418d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/include/llfio/v2.0/detail/impl/posix/map_handle.ipp b/include/llfio/v2.0/detail/impl/posix/map_handle.ipp
@@ -534,7 +534,7 @@ result<map_handle::buffer_type> map_handle::commit(buffer_type region, section_h
   size_type bytes = region.size();
   OUTCOME_TRYV(do_mmap(_v, region.data(), MAP_FIXED, _section, _pagesize, bytes, offset, flag));
   // Tell the kernel we will be using these pages soon
-  if(-1 == ::madvise(region.data(), region.size(), MADV_WILLNEED))
+  if(_section != nullptr && -1 == ::madvise(region.data(), region.size(), MADV_WILLNEED))
   {
     return posix_error();
   }

diff --git a/include/llfio/v2.0/detail/impl/posix/utils.ipp b/include/llfio/v2.0/detail/impl/posix/utils.ipp
@@ -443,7 +443,6 @@ namespace utils
   result<process_cpu_usage> current_process_cpu_usage() noexcept
   {
     process_cpu_usage ret;
-    memset(&ret, 0, sizeof(ret));
 #ifdef __linux__
     try
     {