Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input[type="search"] documentation block #825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the input[type="search"] documentation block #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65e26e
Fix the input[type="search"] documentation block
SiarheiBobryk Sep 6, 2020
5d064ce
Fix comment about `-webkit-appearance` for Chrome
SiarheiBobryk Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,10 @@ decrement button to change from `default` to `text`.

#### `[type="search"]`

The search input is not fully stylable by default. In Chrome and Safari on
OSX/iOS you can't control `font`, `padding`, `border`, or `background`. In
Chrome and Safari on Windows you can't control `border` properly. It will apply
`border-width` but will only show a border color (which cannot be controlled)
for the outer 1px of that border. Applying `-webkit-appearance: textfield`
addresses these issues without removing the benefits of search inputs (e.g.
showing past searches).
The search input is not fully stylable by default. In Safari on
OSX you can't control `font`, `padding`, `border`, or `background`. Applying
`-webkit-appearance: textfield` addresses these issues without removing the
benefits of search inputs (e.g. showing past searches).

## Contributing

Expand Down
2 changes: 1 addition & 1 deletion normalize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ textarea {
}

/**
* 1. Correct the odd appearance in Chrome and Safari.
* 1. Correct the odd appearance in Safari.
* 2. Correct the outline style in Safari.
*/

Expand Down
2 changes: 1 addition & 1 deletion test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ <h3 class="Test-it">should display a default cursor for the decrement button's c
<h2 class="Test-describe"><code>[type="search"]</code></h2>
<h3 class="Test-it">should be styleable</h3>
<div class="Test-run">
<input type="search" style="border:1px solid #ADD8E6; padding:10px; width:200px;">
<input type="search" style="border:4px dashed #ADD8E6; padding:10px; width:200px; font-family:monospace; background-color:#f0f8ff" value="search query">
</div>
<h3 class="Test-it">should reference inherited color</h3>
<div class="Test-run">
Expand Down