Replace project.provider with ProviderFactory.provider for configuration cache compliance

[rpalcolea]

No description provided.

[wakingrufus]

This doesn't look like it actually fixes anything to me. can you add a test to prove that it does?

[rpalcolea]

This follows https://docs.gradle.org/current/userguide/configuration_cache_requirements.html#config_cache:requirements:use_project_during_execution

Replacing project.provider {} with ProviderFactory.provider {}

Also, all tests use configuration cache

nebula-release-plugin/src/integTest/groovy/nebula/plugin/release/GitVersioningIntegrationTestKitSpec.groovy

Line 61 in bd49e92

new File(projectDir, 'gradle.properties') << '''org.gradle.configuration-cache=true'''.stripIndent()

[wakingrufus]

This follows https://docs.gradle.org/current/userguide/configuration_cache_requirements.html#config_cache:requirements:use_project_during_execution

Replacing project.provider {} with ProviderFactory.provider {}

Also, all tests use configuration cache

nebula-release-plugin/src/integTest/groovy/nebula/plugin/release/GitVersioningIntegrationTestKitSpec.groovy

Line 61 in bd49e92

new File(projectDir, 'gradle.properties') << '''org.gradle.configuration-cache=true'''.stripIndent()

yes, but the Project reference is still retained, even though this usage has been removed. is that not still an issue?

[rpalcolea]

Added a few tests in 58282b8

My understanding here is that because we are not trying to serialize the project into the Task graph, we are good. The Project reference is retained in ReleasePluginExtension, but it's only accessed during configuration time where DelayedVersion (which calls infer() → strategy.selector(project, ...)) is resolved eagerly during configuration in BaseReleasePlugin via project.version.toString()

The resolved version string is then passed into task properties (projectVersion.set(...)) as plain values.