fix: check for RSA header before decoding public key #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-power
force-pushed
the
fix/detect-pkcs1-public-key
branch
from
bd08d7c to
41ee28e
Compare
karl-power
commented
Dec 5, 2023
| @@ -241,7 +241,7 @@ test('detectPublicKeyAlgorithms - malformed PEM files should be rejected', t => | |||
| t.end() | |||
| }) | |||
|
|
|||
| test('detectPublicKeyAlgorithms - public keys should be rejected', t => { | |||
| test('detectPublicKeyAlgorithms - private keys should be rejected', t => { | |||
There was a problem hiding this comment.
This is a typo I noticed. The detectPublicKeyAlgorithms function should reject private keys, not public ones.
simoneb
approved these changes
Dec 5, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
The
performDetectPublicKeyAlgorithmsfunction was attempting to decode pkcs1 keys with the pkcs8 decoder. This caused errors when creating the verifier or signer, as the the base64 data structure of each format is different.This PR updates the
publicKeyPemMatcherpattern and checks for the presence of"RSA"in the .pem header, returning the RSA algorithms if found.