Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added map method to query builders #45

Merged
merged 16 commits into from
Mar 1, 2025
Merged

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Jan 30, 2025

  • added map method to change the query result type if you want to construct it some other way around. These methods help to simplify mapping internally (more clean) and provide a big improvement in dev UX on fetching data.

  • Bug-fixed Delegation::view_balance method that returned staked balance instead of unstaked.

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jan 30, 2025

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
We are launching a survey "Who is faster? You vs SpaceX"

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 22 (20 base + 10% lifetime bonus) Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@akorchyn akorchyn changed the title feat: added read_only_with_postprocess method to simplify contract interaction feat: added map method to query builders Feb 3, 2025
Copy link
Collaborator

@dj8yfo dj8yfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this thingy here has to test the same thing that will be published
RUSTDOCFLAGS="-D warnings" cargo doc --all-features --document-private-items

https://github.com/near/near-api-rs/blob/main/.github/workflows/test.yml#L43

@akorchyn
Copy link
Collaborator Author

this thingy here has to test the same thing that will be published RUSTDOCFLAGS="-D warnings" cargo doc --all-features --document-private-items

https://github.com/near/near-api-rs/blob/main/.github/workflows/test.yml#L43

Don't think it related to this PR, though

@dj8yfo
Copy link
Collaborator

dj8yfo commented Feb 12, 2025

Don't think it related to this PR, though

actually , i went to workflows in the target branch to copy an up-to-date command to a local justfile to build documentation with, to look at doc comments added in target branch, and noticed it's out of sync with docs.rs directives in manifest,
so i think it's pretty much related to this pr, despite the referenced line being nowhere close to modified ones

besides, the commented structs/methods (e.g. in src/common/query.rs) reside in a private module, so their addition won't be checked for consistency in ci with cargo doc before attempting to publish

Copy link
Collaborator

@dj8yfo dj8yfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 8
this looks great

left some comments

@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

@akorchyn akorchyn enabled auto-merge (squash) March 1, 2025 09:52
@akorchyn akorchyn merged commit 7218812 into main Mar 1, 2025
11 checks passed
@akorchyn akorchyn deleted the simplify-contract-reuse branch March 1, 2025 11:02
@race-of-sloths
Copy link

🥁 Score it!

@dj8yfo, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

@frol frol mentioned this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants