Fix/multichain test webkit test failing #263
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmalcom
changed the title
| @@ -22,8 +22,11 @@ type TransactionDetail = { | |||
| class SignMultiChain { | |||
There was a problem hiding this comment.
I think this is not the right solution, we can't expect the user to double click it.
I was investigating this and looks like the error comes from the forms validation, as you can see on the video attached. I'm checking how to fix it.
Idk why it only happens in Safari... very weird.
Screen.Recording.2024-07-19.at.14.58.18.mov
There was a problem hiding this comment.
I did some changes on the forms and now it's passing locally with a single click (have to test on the CI yet)
The failing tests are the new ones I introduced. I'm working on it.
I will push the fix on my PR for the EVM function call.
There was a problem hiding this comment.
Hey @Pessina thanks for spotting that, looking forward to your solution. Although the problem here is just on the local form we setup for testing e2e, that is, triggering the local form input click with playwright, we don't have such problem on real implementations like the demo app.
There was a problem hiding this comment.
Yeah, agree, it's a problem only on the e2e app.
But it's better to fix the root problem instead of a quick fix.
I will open the PR soon, I'm struggling a bit with my tests now haha
There was a problem hiding this comment.
Haha okay then.
Do you want me to close this PR then?
There was a problem hiding this comment.
Up to you.
Do you wanna check my solution first, to see if you are happy with it?
There was a problem hiding this comment.
All right then.
Let me wait.
The submit button on this line does not work on first click in webkit browsers, so the transaction does not even submit for the test to run. Until it double clicks.
The quick fix now is to double click the submit button if the browser is webkit, else traditional click.