Make FAST_AUTH_RELAYER_URL configurable #221
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -24,4 +24,5 @@ window.env = { | |||
| SENTRY_DSN: "${SENTRY_DSN}", | |||
| SENTRY_DSN_TESTNET: "${SENTRY_DSN_TESTNET}", | |||
| GIT_COMMIT_HASH: "${GIT_COMMIT_HASH}", | |||
| FAST_AUTH_RELAYER_URL: "${FAST_AUTH_RELAYER_URL}", | |||
There was a problem hiding this comment.
I'm wondering if this is the best approach.
As you can see, on the same config file, we already define RELAYER_URL_TESTNET and RELAYER_URL. With this PR we are introducing a new URL with the same purpose to maintain.
I think we should:
- Wait
https://near-relayer-mainnet.api.pagoda.cosupport/send_meta_tx_async - Refactor the code to accept a base relayer url (eg: www.relayer.com) instead of relayer with path url (eg: www.relayer.com/relay)
There was a problem hiding this comment.
What do you think Danny? I know it will be a bit of work, but I believe it's the path we should go
There was a problem hiding this comment.
Totally agree. Initially I was also had a doubt about whats difference between RELAYER_URL VS FAST_AUTH_RELAYER_URL and why do we have both.
Maybe we revisit this PR when https://near-relayer-mainnet.api.pagoda.co support /send_meta_tx_async
There was a problem hiding this comment.
Cool, let's wait for it and then we work on the refactor :)
This PR closes #220
This PR will allow to configure
FAST_AUTH_RELAYER_URLas per request