Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddDevice screen #146

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Remove AddDevice screen #146

wants to merge 32 commits into from

Conversation

Pessina
Copy link
Collaborator

@Pessina Pessina commented Jan 6, 2024 •
edited
Loading

  • Remove AddDevice screen and move it's logic to the Login screen.
  • Add Spinner for loading state
  • Add forms validation on Login and CreateAccount screens
  • Centralize send e-mails on VerifyEmail screen
  • Clean up isRecovery search param from unnecessary places and use userExist and recoverAccountWithOIDCToken to check user existence

@Pessina
Remove forms from AddDevice screen
3cbeb66
@Pessina
Setup user redirect on Login page
edf6e57
@Pessina
Fix console errors
e50e2b7
@Pessina
Merge remote-tracking branch 'origin/main' into 122-email-form-appear…
9fa865b 
…s-twice-on-signin
@Pessina
Determine isRecovery based on the account's existence on the chain.
ffdefc3
@Pessina
Move sendFirebaseSignInEmail to verify-email
cfef666
@Pessina
Remove AddDevice screen
f0ce596
@Pessina
Remove unnecessary component
e9257be
@Pessina
Remove extra } on verify-email navigate url
4933165
@Pessina
Remove unnecessary code
6ac130c
@Pessina
Fix invalid-code bug
5db5dd1
@Pessina
Replace firebaseAuth with getFirebaseAuth
c671cb7
@Pessina
Resolve signAndSendAddKey json before use it
d4afea6
@Pessina
Add loading on Login screen
bfbb5af
@Pessina
Revert getFirebaseAuth changes and wrap auth on useCallback
e4cfdd9
@Pessina
Fix bug calling useHandleAuthenticationFlow twice
7837786
@Pessina
Merge remote-tracking branch 'origin/main' into 122-email-form-appear…
7c8e79b 
…s-twice-on-signin
@Pessina
Replace flashing forms with continuos loading
fd64f6b
@Pessina
Move sendFirebaseEmail to verify-email
15654b1
@Pessina
Fix loading issues
8d69f3b
@vercel Vercel
Copy link

vercel bot commented Jan 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 6:08pm

hcho112
hcho112 reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! so code wise, it looks good.
I have conducted following tests:

Chrome Test

Create account
Sign in above
Sign in using cognito with above account
Sign in using safari browser with above account
Reach Delete key and continue sign in

Safari Test

Sign in above

Firefox test

Sign in
Create account

It looks good so far. For Firefox, we need this PR ready in order to check for FAK functionality check.

I will leave @esaminu for final approval. (Please try to have a test independently on your side just in case)

@Pessina Pessina changed the title Remove AddDevice screen [DRAFT] Remove AddDevice screen Jan 12, 2024
@Pessina Pessina changed the title [DRAFT] Remove AddDevice screen Remove AddDevice screen Jan 17, 2024
@Pessina Pessina mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho112 hcho112 hcho112 left review comments

@esaminu esaminu esaminu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessina @esaminu @hcho112