fix(nft): fix internalNFTRevokeAll function#11
Open
therealharpaljadeja wants to merge 1 commit intonear-examples:5.approvalfrom
Open
fix(nft): fix internalNFTRevokeAll function#11therealharpaljadeja wants to merge 1 commit intonear-examples:5.approvalfrom
therealharpaljadeja wants to merge 1 commit intonear-examples:5.approvalfrom
Conversation
`internalNFTRevokeAll` function checked if there are no `approved_account_ids` only then it would go ahead and revoke, which is contradictory 😅. Made the fix to revoke when there are `approved_account_ids` in `token`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internalNFTRevokeAllfunction checked if there are noapproved_account_idsonly then it would go ahead and revoke, which is contradictory 😅. Made the fix to revoke when there areapproved_account_idsintoken.