WIP: Try out higher version (3.5.5) and Java 17 compile on starter compared to master#334
Open
alx652 wants to merge 22 commits into
Open
WIP: Try out higher version (3.5.5) and Java 17 compile on starter compared to master#334alx652 wants to merge 22 commits into
alx652 wants to merge 22 commits into
Conversation
…s from the LegacyAuthenticationFilter class
This is development code. It needs to be tested and reviewed and modified
changes made to get test to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is a child of springBoot3x, springBoot3x_try_merge_3.2.0, springBoot3x_try_merge_3.4.9) merged with 3.1.3-SNAPSHOT master
This builds but tests fail
gsrs-spring-starter-tests/src/test/java/gsrs/startertests/GsrsSpringApplication.java
The conditional on missing bean causes problems,
@ConditionalOnMissingBean(UserProfileRepository.class)
if I disable it the next thing that happens is
Try running CreateAndModifyDateFieldTest.java
intialCreationShouldSetCreateDateAndLastModifiedToSameValue
Caused by: org.hibernate.AnnotationException: Property 'gsrs.stagingarea.model.ImportData.recordId' is annotated @GeneratedValue but is not part of an identifier