Merged
Conversation
I hope we aren't using any more globally initialized classes, because it seems they're broken! (reset to 0 because the app loads nbcraft TWICE!! before android_app_entry gets a chance to run)
Yeah turns out `= nullptr;` is a whole ahh static initialization with a function in .init_array instead of just clearing the value to 0
Member
Author
|
This PR is now ready. I can now compile an android APK for NBCraft with this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Seems like globally initialized objects are broken, because only making
AppPlatform_androida pointer in main.cpp fixed a crash issue regardingAppPlatform::m_singletonseemingly being cleared.For some reason, it seems like libnbcraft.so is loaded twice? Didn't happen in the last PR.
