Conversation
|
|
||
| android { | ||
| namespace 'com.reminecraftpe' | ||
| namespace 'com.nbcraft' |
There was a problem hiding this comment.
Was com.reminecraftpe for like 2 years and nobody complained.
There was a problem hiding this comment.
we're using org.nbcraft everywhere, and org.nbcraft.nbcraft instead of io.github.reminecraftpe
There was a problem hiding this comment.
just let me do it cuz i was already working on this, just gotta fix macos CI
There was a problem hiding this comment.
If we use org.nbcraft for both, then there will be package confusion between the Android native activity-based version and the SDL2 version.
There was a problem hiding this comment.
One should be called org.nbcraft.nbcraft-sdl2 and the other org.nbcraft.nbcraft-native or whatever. Perhaps native just gets org.nbcraft.nbcraft. I have a similar naming for the Xcode and VS clients. NBCraftClient.SDL2, NBCraftClient.Win32, NBCraftClient.iOS, etc.
Don't know if it compiles. The PR is there, and I'm just gonna compile both and test.
|
Please do not pull yet as I don't know if this works. |
|
Android native turns out to be broken in more ways than one |
|
@Un1q32 you can take care of the SDL rename, I'll undo my own commits for SDL Android and I'll rename this PR to "fix android native + rebrand" or something |
|
To fix android native you would have to fix the OpenSL backend |
Turns out it was completely broken! probably since the "MinGW support + CMake refactor" (5ef48b8) commit.
|
will be finished in another PR. |
3 participants
As part of the ongoing rebrand.